pyemscripten_2026_0 (fixed whl tag) - #2
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions build workflow to ensure the produced wasm wheel is consistently retagged with the intended Emscripten/Pyodide platform tag, aligning the artifact naming with the target runtime expectations.
Changes:
- Adds a
platform_tagfield to the workflow matrix (with a commented example for older Pyodide). - Retags the generated wheel unconditionally using the matrix-provided
platform_taginstead of conditional logic tied to Pyodide version.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| python3 -m venv /tmp/wheel-retag-env | ||
| /tmp/wheel-retag-env/bin/pip install -q "wheel<0.45" | ||
| /tmp/wheel-retag-env/bin/wheel tags \ |
There was a problem hiding this comment.
The workflow already installs wheel<0.45 in the main Python environment (see the "Install maturin + wheel" step). Creating a separate venv and re-installing wheel here is redundant and adds extra runtime/complexity; consider reusing the existing environment and invoking python -m wheel tags ... directly (or otherwise documenting why isolation is required).
| python3 -m venv /tmp/wheel-retag-env | |
| /tmp/wheel-retag-env/bin/pip install -q "wheel<0.45" | |
| /tmp/wheel-retag-env/bin/wheel tags \ | |
| python3 -m wheel tags \ |
No description provided.