Repository navigation
Add CMake build support for CBLAS - #34
Merged
Merged
Conversation
Owner
|
The bug related to the 2 failures is fixed. |
Contributor
Author
|
Thank you for the update and the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background: On my system (Ubuntu 24.04 LTS with 16 physical cores), the bundled CBLAS build is roughly 20% faster than the system BLAS build for a benchmark
factor/solveon a KKT-system with roughly 1M nnz float64 elements.The top level cmake build has support for using the bundled CBLAS instead of the system BLAS, but the CBLAS directory lacks the CMake file required for this build.
The PR adds the support for cmake builds using the bundled CBLAS.
Testing: After the build, the CTest fails on two tests (out of 48 tests) on my system. The failures are not the result of added CMake file. I reproduced the failed tests using the build with legacy make system. A small script (
reproduce_test_failures_build.sh) attached can be used to reproduce the issue. The outputs from both builds (cmake and make) is also attached.reproduce_test_failures_build.sh
tests_with_make.txt
tests_with_cmake.txt