chore: split libphonenumber-js into a separate chunk - #269
Open
arisuryaa wants to merge 1 commit into
Open
Conversation
arisuryaa
commented
Aug 23, 2026
arisuryaa
commented
Contributor
- add manualChunks to esm-bundled output config in sdk/build.ts
* add manualChunks to esm-bundled output config in sdk/build.ts
arisuryaa
requested review from
seanyu4296 and
yanoandri
and removed request for
seanyu4296 and
yanoandri
August 23, 2026 15:36
Contributor
|
Does this allow initialization before the chunk loads? I don't think it does, since its using synchronous imports. It looks like this just delays startup because now it needs to separately fetch libphonenumber before the main import resolved. Can you change it to an async import and trigger it to load at the same time the session is being loaded? |
Contributor
Author
|
Yeah the loading process is still synchronous, Okay, Simon, I'll try changing that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.