Skip to content

forcing HTTP scheme for insecure registry - #79

Open
qwentb wants to merge 1 commit into
xelalexv:masterfrom
qwentb:bugfix-http-registries
Open

forcing HTTP scheme for insecure registry#79
qwentb wants to merge 1 commit into
xelalexv:masterfrom
qwentb:bugfix-http-registries

Conversation

@qwentb

@qwentb qwentb commented Jul 1, 2022

Copy link
Copy Markdown

Even when configuration contains skip-tls-verify: true if the registry has a prefix different than localhost the Registry.Scheme is always https, and the catalog retrieval fails.

@xelalexv

Copy link
Copy Markdown
Owner

I think there are two 'levels' of insecure here. The meaning of skip-tls-verify: true is quite literally to skip TLS verification of the server, but not to drop to HTTP. It's still doing HTTPS. The other 'level' would be plain HTTP. If we want to support that, we need to distinguish it from Skip-TLS-Verify, i.e. we would probably have to introduce a new config option such as insecure: true for this. Also, naming of the flag for Skip-TLS-Verify as insecure in existing code is bit misleading and needs to be changed for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants