Add FlashSAC agent for high-throughput off-policy training - #122
Open
tmjeong1103 wants to merge 1 commit into
Open
Add FlashSAC agent for high-throughput off-policy training#122tmjeong1103 wants to merge 1 commit into
tmjeong1103 wants to merge 1 commit into
Conversation
tmjeong1103
marked this pull request as ready for review
August 7, 2026 02:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation notes
[-1, 1]and use MimicKit's action normalizer to map to the environment bounds.FAILandSUCCare terminal states;TIMEis treated as a truncation so the critic can bootstrap.torch.compileremains opt-in because its behavior is PyTorch-version dependent.The implementation follows the public FlashSAC PyTorch repository at commit
87edc9061150ae9e962dd84e6544e27a1554b3abwhile adapting environment interaction and persistence to MimicKit conventions.Validation
python -m unittest discover -s tests -p "test_flashsac*.py" -vgit diff --checkpasses.One-hour wall-clock comparison
The following is a single-seed descriptive comparison using 4,096 environments on one RTX 3090 Ti. Both agents received the same one-hour wall-clock budget. Reported values use deterministic 256-environment evaluation and causal wall-clock alignment.
This benchmark is intended as integration evidence rather than a statistical-significance or exact paper-reproduction claim.
G1 kick combo
G1 speed vault
G1 cartwheel
Example
python mimickit/run.py \ --arg_file args/deepmimic_g1_flashsac_args.txt \ --mode train \ --visualize falseThe included example reduces replay capacity and uses
n_step: 1to lower memory requirements. The documentation distinguishes these choices from the larger settings used by the reference IsaacLab launcher.References
87edc9061150ae9e962dd84e6544e27a1554b3abAttribution
The original FlashSAC MIT license is included at
LICENSES/FlashSAC-MIT.txt, and the documentation includes the paper citation and source commit used for the adaptation.