Skip to content

fix(ground-truth): record dbf_stations rows in field order - #13

Open
ihibti wants to merge 1 commit into
xberg-io:mainfrom
ihibti:fix/dbf-stations-ground-truth
Open

ihibti wants to merge 1 commit into
xberg-io:mainfrom
ihibti:fix/dbf-stations-ground-truth

Conversation

@ihibti

@ihibti ihibti commented Sep 29, 2026 •

Copy link
Copy Markdown

Related

xberg-io/xberg#1968, fixed by xberg-io/xberg#1969.

Description

ground_truth/dbf/dbf_stations.txt was recorded from xberg output while the DBF extractor read each record through a HashMap, so every row's cells sit in a random order under the header: its first row is | blue | rail-metro | Van Dorn Street | #0000ff |, where dbf/stations.dbf stores Van Dorn Street, #0000ff, rail-metro, blue.

This rewrites each row in the declared field order, read directly from the DBF bytes rather than from xberg. 82 of the 86 rows change. Every row keeps exactly the same values, and the header, record order, line count and trailing newlines are unchanged, so the benchmark's bag-of-words scores do not move. The path is unchanged.

The file was recorded from xberg output while the DBF extractor walked
each record's HashMap, so every row's cells came out in a random order
under the header. Rewrite each row in the declared field order read from
dbf/stations.dbf; every row keeps exactly the same values, so the
bag-of-words scores the benchmark computes are unchanged.

Refs xberg-io/xberg#1968
Copilot AI balanced review requested due to automatic review settings September 29, 2026 21:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Goldziher Goldziher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified all 86 rows against the DBF source field descriptors and record order. The change preserves every field value, row count, header, and trailing blank line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants