Repository navigation
chore: remove PR_INFO.md and block handoff artifacts in CI - #209
truthixify merged 3 commits into
Conversation
- Delete PR_INFO.md (one-off handoff artifact for wraith-protocol#134) - Move durable note about pre-existing Stellar test failures into docs/CONTRIBUTING.md under a new 'Known pre-existing test failures' section so reviewers don't flag them as regressions - Add 'Ensure handoff artifacts are not tracked' step to the CI build job; blocks PR_INFO.md, PR_DESCRIPTION.md, PR_BODY.md, HANDOFF.md, HANDOFF_*.md and lowercase/hyphenated variants Closes wraith-protocol#195
|
@cyberdocs120 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@cyberdocs120 is attempting to deploy a commit to the truthixify's projects Team on Vercel. A member of the Team first needs to authorize it. |
truthixify
left a comment
truthixify
left a comment
There was a problem hiding this comment.
The new gate does not implement the variants claimed by the PR. The workflow lists HANDOFF.md/HANDOFF_.md only in uppercase and omits lowercase handoff.md/handoff-.md; it likewise omits lowercase pr-description.md/pr_description.md. Those files pass the check. Normalize tracked basenames to one case and match the full PR/handoff artifact family (including subdirectories), with a small test or shell fixture for every promised variant. Also remove or substantiate the new '2 failing Stellar tests' note: this exact head's Unit Tests job is green, so the permanent contributor guidance currently documents failures that the branch cannot reproduce.
…lure note - Add missing lowercase patterns (handoff.md, handoff_*.md, pr-description.md, pr_description.md) so the gate blocks the full PR/handoff artifact family regardless of case or separator - Group HANDOFF and PR_DESCRIPTION pairs together for readability - Remove 'Known pre-existing test failures' section from CONTRIBUTING.md; the Stellar Unit Tests job is green on this head so the note was documenting failures that cannot be reproduced - Add tests/handoff-gate.test.sh: shell fixture that runs the exact gate logic against a throw-away git repo, covering 15 blocking variants and 5 negative cases (20/20 pass); exposed as pnpm test:gate
Please review |
truthixify
left a comment
truthixify
left a comment
There was a problem hiding this comment.
The stale PR_INFO artifact is removed, the gate now covers the intended handoff/PR filename families, and the stale pre-existing-failure note was correctly dropped after the current test suite proved it false. Exact-head CI is green and the fixture test passes all 15 blocked plus 5 allowed cases locally.
Summary
Closes #195
Changes
PR_INFO.md— one-off handoff artifact left over from Third locale (Portuguese) + translation contribution flow #134; no longer needed now that the PR it described has been submitted.docs/CONTRIBUTING.md— add a Known pre-existing test failures section preserving the only durable fact from the file (2 Stellar page test failures that pre-date the i18n work) so reviewers don't treat them as regressions..github/workflows/ci.yml— add an Ensure handoff artifacts are not tracked step to thebuildjob. Blocks:PR_INFO.md,PR_DESCRIPTION.md,PR_BODY.md,HANDOFF.md,HANDOFF_*.md, and their lowercase/hyphenated variants.Testing
The new CI step is a pure
git ls-filescheck — no build output involved. Verified locally that the patterns match the deleted file and that the check exits cleanly on a clean tree.