Skip to content

fix(auction): classify bid submission outcomes before releasing recovery material - #241

Merged
truthixify merged 4 commits into
wraith-protocol:developfrom
Adedoyinjr:fix/bid-lifecycle-clean
Oct 24, 2026
Merged

truthixify merged 4 commits into
wraith-protocol:developfrom
Adedoyinjr:fix/bid-lifecycle-clean

Conversation

@Adedoyinjr

Copy link
Copy Markdown
Contributor

Summary

  • Safely classify bid submission outcomes before releasing recovery material.
  • Preserve recovery secrets when transaction status is uncertain.
  • Reconcile pending submissions using authoritative transaction status.
  • Add regression tests for bid submission and reconciliation.

Supersedes #238

Closes #238

@vercel

vercel Bot commented Oct 23, 2026

Copy link
Copy Markdown

@Adedoyinjr is attempting to deploy a commit to the truthixify's projects Team on Vercel.

A member of the Team first needs to authorize it.

Format src/lib/stellar/names.ts, src/pages/NamesAuctions.tsx,
src/store/nameWatchlistStore.tsx, src/lib/stellar/auctionBidReconciliation.test.ts,
and src/lib/stellar/auctionBidSubmission.test.ts per the repository's
prettier configuration. No behavioral changes.

@truthixify truthixify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested on exact head 3ccee4a. The submission/reconciliation behavior is now correct and the focused suites pass 38/38, but the required build gate is red because format:check fails on auctionBidReconciliation.test.ts, auctionBidSubmission.test.ts, names.ts, NamesAuctions.tsx, and nameWatchlistStore.tsx. Format those files and rerun CI. This head has the same tree as #238, so please coordinate one canonical PR to avoid duplicate merges.

@Adedoyinjr

Copy link
Copy Markdown
Contributor Author

Hi, I fixed the Prettier formatting issues for PR #241 in commit 33eaf3a, based on the PR's original head 3ccee4a. The fix is pushed to Adedoyinjr/www:fix/bid-lifecycle-clean, and the formatting, tests, and build pass locally. I don't have write access to Adedoyinjr/demo, so could someone with access sync this commit to fix/bid-lifecycle-clean and let CI rerun? PR #238 and PR #241 also need coordination so only one canonical PR is merged.

kilo-code-bot Bot and others added 2 commits October 23, 2026 23:01
Upgrade toml override from 4.2.0 to 5.0.1 (fixes 3 high-severity
CVEs: GHSA-4qx8-w7c3-pj3p, GHSA-9j65-hcg3-gc64, GHSA-9qmh-m7c6-f92p)
and add zod override at 4.6.6 (fixes GHSA-mrhx-c7xc-m3w5).

Update SECURITY_AUDIT.md: remove braces from accepted findings (no
longer vulnerable), update result table (high 1→0), update overrides
table, update CI gate description (high ≤ 0).

Update scripts/audit-gate.mjs: MAX_HIGH from 1 to 0.
Update dependency-compatibility test: toml version expectation 4.x→5.x.
@Adedoyinjr
Adedoyinjr requested a review from truthixify October 23, 2026 23:18

@truthixify truthixify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remote malware screening passed again on exact head 5e280c3. Build and repository checks are green. Local verification passed the production build, 60 focused auction/recovery tests, and the production audit gate with 0 critical and 0 high findings. The revised lifecycle preserves recovery material and reconciles ambiguous submissions only from authoritative transaction status.

@truthixify
truthixify merged commit e0b9d4e into wraith-protocol:develop Oct 24, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants