Fix repeat contributor detection - #17
Open
GodHad wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates first-time contributor detection to use GitHub search result counts instead of checking only the first page returned by
issues.listForRepo.The previous implementation listed repository issues/PRs created by the author and then checked whether the filtered first page had exactly one result. For contributors with older prior activity beyond the first page, this could incorrectly treat them as first-time contributors.
Motivation and Context
Fixes #16
This change prevents the welcome action from occasionally commenting on issues or pull requests opened by repeat contributors, veteran contributors, or maintainers.
Then it only posts the welcome comment when
total_count === 1.Types of changes
Self Check before Merge