Skip to content

Update the media_container::server::Feature enum - #727

Open
worried-networking wants to merge 1 commit into
mainfrom
auto-pr/feature-enum-update
Open

Update the media_container::server::Feature enum#727
worried-networking wants to merge 1 commit into
mainfrom
auto-pr/feature-enum-update

Conversation

@worried-networking

Copy link
Copy Markdown
Owner

Automated changes by create-pull-request GitHub action

@worried-networking worried-networking added the C-Dependencies Pull requests that update a dependency file label Jun 2, 2026
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The pull request updates Feature enum serialisation for two variants, marks RwpIntroPriceCopy deprecated, and removes its mocked v2 feature entry.

Changes

Feature enum variant updates

Layer / File(s) Summary
Feature serde mappings
crates/plex-api/src/media_container/server/feature.rs
Feature::Ipv6Setting and Feature::Plexpass5YearSku gain explicit #[serde(rename, alias)] attributes for serialisation mapping.
RwpIntroPriceCopy deprecation and mock update
crates/plex-api/src/media_container/server/feature.rs, crates/plex-api/tests/mocks/myplex/api/v2/features.json
Feature::RwpIntroPriceCopy is annotated with #[deprecated], and the matching entry is removed from the v2 feature mock array.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is related, but it is too generic to convey anything meaningful about the changeset. Replace it with a short summary of the actual enum and test fixture updates made in this PR.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: updating the media_container::server::Feature enum.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch auto-pr/feature-enum-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 2, 2026
@mergify mergify Bot added the S-Run-Protected-Tests Waiting for the tests to be executed label Jun 2, 2026
@worried-networking
worried-networking force-pushed the auto-pr/feature-enum-update branch from a462b30 to e9a7a3e Compare June 9, 2026 00:38
@mergify

mergify Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 23, 2026
@codecov-commenter

codecov-commenter commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.29%. Comparing base (17fd827) to head (523ce30).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #727   +/-   ##
=======================================
  Coverage   61.29%   61.29%           
=======================================
  Files          33       33           
  Lines        2090     2090           
=======================================
  Hits         1281     1281           
  Misses        809      809           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@worried-networking
worried-networking force-pushed the auto-pr/feature-enum-update branch from 523ce30 to 8c4b604 Compare July 21, 2026 02:08
@worried-networking
worried-networking force-pushed the auto-pr/feature-enum-update branch from 8c4b604 to 026701f Compare August 11, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Dependencies Pull requests that update a dependency file S-Run-Protected-Tests Waiting for the tests to be executed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants