fix: regenerate api.txt for networkmock modules and add metalava PR check#65
Merged
Merged
Conversation
Regenerates api.txt for devview-networkmock and devview-networkmock-core to reflect API changes introduced in 0.1.3 (NetworkMockResourceLoader, responseSuffixes, query param matching, delay support). Deletes the stale 0.1.3.txt snapshots and reverts the release prep so release.py can re-run cleanly for 0.1.3. Also fixes MetalavaConventionPlugin to declare explicit task dependencies on generateComposeResClass and generateExpectResourceCollectors, which resolves implicit dependency validation errors when running with --configuration-cache. Adds a metalava CI job to build.yml (runs on macOS to include iOS APIs) so stale api.txt is caught at PR time, not at publish time. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api.txtfordevview-networkmockanddevview-networkmock-coreto reflect API changes introduced before 0.1.3 (NetworkMockResourceLoader fun interface, responseSuffixes parameter, query param matching, delay support in models) that were never recorded — this was the root cause of thepublish.ymlfailure for the 0.1.3 tag0.1.3.txtsnapshots for those two modules (release.py will recreate them correctly when we re-run the release)0.1.3-SNAPSHOT, changelog, docs/index.md) sorelease.pycan re-run cleanlyMetalavaConventionPluginto declare explicit task dependencies ongenerateComposeResClassandgenerateExpectResourceCollectors, resolving implicit dependency validation errors when running with configuration cachemetalavaCI job tobuild.yml(runs on macOS, nodisableAppleTargets, so iOS-specific APIs are included) — ensures staleapi.txtis caught at PR time, not at publish timeAfter merging
Delete the old 0.1.3 tag and re-run the release script:
Test plan
metalavaCheckCompatibilitypasses in the new CI job on macOSpublish.ymltriggered by the new 0.1.3 tag passes the build job🤖 Generated with Claude Code