test(router): cover workload-identity keys with no stored ciphertext - #1018
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
test(router): cover workload-identity keys with no stored ciphertext#1018devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
|
PR author is not in the allowed authors list. |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Claude finished @devin-ai-integration[bot]'s task —— View job No comment-length issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression test for #1017, run against a real Postgres + real Tink AEAD: a
wifrow (emptykey_ciphertext, the column is NOT NULL) plus a normal bearer row on the same installation. Onmainbefore #1017 it fails with the exact production error,aead_factory: decryption failed, and takes the bearer key down with it — which is the part that mattered.Gated on
ROUTER_TEST_DATABASE_URLlikeflag_definitions_test.go, so CI's databaselessgo testskips it.Link to Devin session: https://app.devin.ai/sessions/271f32100a214fe6bc5ec69d96f13b18
Requested by: @steventohme