Skip to content

fix(dashboard): keep the space in import rule summaries - #476

Merged
RedStar071 merged 1 commit into
refactor/v3from
fix/v3-import-preview
Oct 20, 2026
Merged

RedStar071 merged 1 commit into
refactor/v3from
fix/v3-import-preview

Conversation

@RedStar071

@RedStar071 RedStar071 commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Stacked on #451.

🔗 Linked issue

Related to #451.

🧭 Context

Vue drops whitespace that opens an element, so the import preview printed Created (2):Too many lines with no gap between the label and the rule names.

📚 Description

The separator now sits inside the interpolation, so every rule summary (created, edited, moved, deleted) keeps it.

🤖 AI disclosure: Wolfstar Agent Kit modified this description. AI open source policy.

RetriggerView in GreptileConfidence Score: 5/5

Safe to merge. Browser checks confirm that all four import summary categories retain the separator and preserve the rule names.

Summary

Keeps a space between each import summary label and its rule names.

  • Import previews keep a space between rule labels and names.

Reviews (1) · Last reviewed commit: "fix(settings): keep the space in import ..." · Reviewed by Greptile

Vue drops whitespace that opens an element, so the import preview read
"Created (2):Too many lines". Put the separator inside the interpolation.
@coldtea-pr-lens

coldtea-pr-lens Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Architecture

Architecture diagram for wolfstar-project/wolfstar.rocks at 1b0cddf

Open the canvas


Data flow

No data-flow sequence changed in this PR.


Review

✨ Nothing flagged · reviewed 1b0cddf


Tip

Open a diagram on the canvas, then press W or click play to walk through the change one step at a time

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through
  • The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture and data flow row. Drawing still runs as before
  • Set github.draw: on-demand in .github/pr-lens.yml and PR Lens stops drawing pull requests on its own. Comment @pr-lens draw on a pull request when you want that one drawn
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works
  • After a push, tick Redraw to draw the latest commit
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion

Thanks for using PR Lens! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out on X, Bluesky, Mastodon, Reddit or LinkedIn

@wolfstar-github-agent

Copy link
Copy Markdown
Contributor

🤖 REVIEW PAUSED

Wolfstar Agent Kit posted this automated status. AI open source policy.

This pull request is from an outside contributor.

Add the wolfstar-agent-review label to approve automated review and verified repairs.
Approval covers head commit 1b0cddfc1b26.

  • Review and repair

Only Wolfstar's click starts work. It adds the wolfstar-agent-review label.

@RedStar071 RedStar071 changed the title fix(settings): keep the space in import rule summaries fix(dashboard): keep the space in import rule summaries Oct 20, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: the full single-commit diff (2 files).

  • Rule summary spacing: Transfer.vue moves the separator into the interpolation ({{ " " + line.names }}). Vue strips a whitespace-only text node at the start of an element's children, so the old literal space was dropped. All four rule lines (created, edited, moved, deleted) share this one template, so the fix covers each of them.
  • Test tightened: Transfer.spec.ts now asserts "Created (1): Fresh" and "Deleted (1): Old". The old assertions checked label and names separately, so they could not catch the missing gap.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@github-project-automation github-project-automation Bot moved this from Backlog to Ready in Wolfstar Site Oct 20, 2026
@RedStar071
RedStar071 merged commit ad973e7 into refactor/v3 Oct 20, 2026
12 of 15 checks passed
@RedStar071
RedStar071 deleted the fix/v3-import-preview branch October 20, 2026 12:39
@github-project-automation github-project-automation Bot moved this from Ready to Done in Wolfstar Site Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant