fix: axTree() window and budget reporting say what actually happened - #16
Merged
Merged
Conversation
Asking for window 1 on an app with one window fell through to walking the application element: a larger, different tree with no window frame, returned as though it answered the question. It now fails with the count the app actually exposes, and distinguishes the case where there are no accessibility windows at all (minimised or hidden). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
maxElements caps the walk, and pruning runs afterwards, so a result could show elements: 315 next to maxElements: 400 and capped: true — three numbers that read as a contradiction. budget.walked is what the cap applies to; elements is what came back. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
woladi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while wiring
uiSnapshotinto the MCP server.axTree({ app: 'Safari', window: 1 })on an app with one window did not fail — it fell through to walking the application element instead. That returns a larger, different tree and nowindowframe, presented as though it had answered the question:Now it fails with the count the app actually exposes, and says so separately when an app exposes no accessibility windows at all (minimised or hidden).
10 tests over
axTree, 105 total.🤖 Generated with Claude Code