Nested Compositions - #74
Closed
wol-soft wants to merge 1 commit into
Closed
Conversation
Pull Request Test Coverage Report for Build 5119595183
💛 - Coveralls |
Owner
Author
|
Superseeded by #166 |
wol-soft
pushed a commit
that referenced
this pull request
Jul 27, 2026
PR #74 targeted two composition bugs reported against a FedEx OpenAPI schema: a crash on deeply nested allOf $ref chains, and oneOf branches containing only an "example" keyword matching every input. The PR's own code no longer applies (the composition architecture it patched was fully rewritten since), so only its test schemas are reconstructed here against current master, pinning the verified current behavior: - Deeply nested allOf no longer crashes, but the composed property is never instantiated as an object (getCEO() returns a raw array despite a nested @return annotation). - A root-level oneOf with an example-only branch still fails generation with "No nested schema for composed property" - a stricter form of the original crash. - The same branch nested inside a property lets generation succeed, but the example-only branch is never skipped during validation, so valid input is rejected for matching two branches instead of one. See .claude/issues/72/analysis.md and implementation-plan.md for the full investigation and the patches still needed; no fix is applied in this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.