Support TimeDelta columns in Median and Percentiles - #824
Open
ChrisJr404 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wraps up the Median half of #761. Sum and Mean already accept TimeDelta columns, so it was a bit surprising that Median still raised a DataTypeError on them, especially since timedeltas sort and average just fine.
The only thing in the way was the type check. Percentiles does the actual work for Median, and its arithmetic (averaging the two adjacent values and dividing by two) already works on timedeltas, so I loosened the check in both Percentiles and Median to allow TimeDelta alongside Number, and made Median.get_aggregate_data_type return the column's own data type the way Sum and Mean do. The rest of the percentile family (Quartiles, Quintiles, Deciles, IQR, MAD) validates for Number on its own, so nothing else changes.
Added tests for median and percentiles over a timedelta column plus an all-nulls case, and a changelog line.