Add selective inline typing for Aggregation - #823
Open
heejaechang wants to merge 2 commits into
Open
Conversation
Provide exact generic result relationships for Aggregation, First, and Summary while leaving dependency-bound aggregation modules untyped. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Move the exact generic Aggregation contract into runtime source while preserving its Python 3.10 MRO and runtime behavior. Remove the concrete sidecars whose untyped Table, Column, and DataType dependencies cannot satisfy strict inline checking without erasure or suppressions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agate.aggregations.base.Aggregationpy.typedmarker.pyifiles proposed in closed Add inline typing for Aggregation #822This replaces closed #822 in response to the maintainer feedback: #822 (comment)
Only fully proven exact annotations are retained.
FirstandSummarywere deliberately left unannotated because their runtime bodies cross wholly untypedTable,Column, andDataTypesurfaces. The change uses noAny,objecterasure, casts, ignores, invented protocols, variadic escapes, or broad-union workarounds.Validation