Repository navigation
Keep the feedback UI in the semantics tree - #416
Merged
Merged
Conversation
The app's route barriers (BlockSemantics) hid the Wiredash content painted before the app, so with semantics on the text field couldn't be focused and buttons ignored taps.
percula
marked this pull request as ready for review
October 28, 2026 14:20
Address avoid_setup_teardown by registering addTearDown beside handle creation so failed setup or assertions still release it. Dispose on success before Flutter 3.19 checks active handles, then clear the reference to prevent double disposal.
Address write_changelogs by linking the release note to PR wiredashio#416 so package consumers can trace the fix and its regression test.
Use the rendered view pipeline owner instead of the deprecated binding.pipelineOwner API. CI treats deprecation infos as fatal; the replacement works on the minimum Flutter 3.19 SDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With semantics enabled (a screen reader, or a web app that turns semantics on), the feedback flow can't be used: the message field can't be focused and the buttons don't respond to taps, though hover effects still show.
The backdrop stacks the Wiredash content before the app. The app's routes each put a
ModalBarrierin the tree, and itsBlockSemanticsdrops the semantics of everything painted before it up to the nearest container, so the Wiredash UI disappears from the semantics tree. Wrapping the app inSemantics(container: true)keeps the barriers scoped to the app. Added a test that fails without the fix.