fix: conversation and users names cut with large font (WPB-15168)#5002
fix: conversation and users names cut with large font (WPB-15168)#5002sbakhtiarov wants to merge 2 commits into
Conversation
| @Composable | ||
| @ReadOnlyComposable | ||
| fun maxTitleLines(): Int = if (LocalDensity.current.fontScale > DEFAULT_FONT_SCALE) { | ||
| EXPANDED_FONT_SCALE_MAX_LINES | ||
| } else { | ||
| DEFAULT_FONT_SCALE_MAX_LINES | ||
| } |
There was a problem hiding this comment.
should we have it either 1 or 4 or maybe add a bit more scaling?
There was a problem hiding this comment.
not sure what you mean by "a bit more scaling". This is for maxLines value, so that the full title is visible, but it will not take full 4 lines unless it is needed.
There was a problem hiding this comment.
i mean depending on the font scale and how big it is
if there is a small difference between DEFAULT_FONT_SCALE and device then keep 1
a bigger difference use 2
and a large difference use 4
There was a problem hiding this comment.
not sure if it is worth it, I really wanted to keep it simple
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5002 +/- ##
========================================
Coverage 49.31% 49.31%
========================================
Files 650 650
Lines 23457 23457
Branches 3606 3606
========================================
Hits 11568 11568
Misses 10813 10813
Partials 1076 1076 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
4 participants
https://wearezeta.atlassian.net/browse/WPB-15168
https://wearezeta.atlassian.net/browse/WPB-15168
What's new in this PR?
Issues
Conversation and user names are not fully displayed when large font is set in accessibility settings.
Solutions
Use more lines for conversation and user names when font scaling is appied.