Repository navigation
add multipart content to MessageEdit - #98
Merged
Merged
Conversation
jullianm
requested review from
johnxnguyen,
netbe and
samwyndham
and removed request for
netbe
December 15, 2025 14:13
|
johnxnguyen
approved these changes
Dec 16, 2025
samwyndham
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
This PR introduces a new use case
Multipartfor theMessageEditcontent (in addition to the already existingTextandComposite) so edited messages that have multipart attachments can be correctly handled on iOS. This change is also needed as we'll later be able to edit attachments as well.Note: this change was approved by iOS, Web and Android.