Repository navigation
Guard the server lock under every spelling of its name - #73
Merged
Merged
Conversation
The guard matched /etc/heinzel.conf as a literal path, so an uppercase name on macOS, a doubled slash or a relative path after cd lifted the lock unseen. Matching the file name in any case closes those, at the cost of also denying writes to any other file called heinzel.conf; globs and names built at run time stay out of reach of a pattern. An AI agent wrote this text in my name. I know that is problematic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #72. The guard now matches
heinzel.confby name in any case, so/ETC/HEINZEL.CONFon macOS,/etc//heinzel.conf,cd /etc && rm heinzel.confandfind … -deleteare denied too. A glob or a name built at run time still gets past a pattern, as the code comment says. Guard tests: 816 passed, 0 failed. Bumps to 3.1.1.An AI agent wrote this text in my name. I know that is problematic.