cleanup: `*` not supported

[brian6932]

Version

sfsu 1.17.1

Error Report

N/A

Description

I for the longest time have used scoop cleanup * -g as * was a thing before the -a/--all flag existed, recently I noticed that it was immediately returning All squeaky clean!!, so I assume it's not currently supported.

Steps to Reproduce

sfsu cleanup *

Expected Behavior

It's built into scoop.ps1 cleanup, so it needs to be supported when using sfsu sub-commands as scoop replacements.

Actual Behavior

All squeaky clean!!.

Additional Context

❯ scoop.ps1 cleanup -h
Usage: scoop cleanup <app> [options]

'scoop cleanup' cleans Scoop apps by removing old versions.
'scoop cleanup <app>' cleans up the old versions of that app if said versions exist.

You can use '*' in place of <app> or `-a`/`--all` switch to cleanup all apps.

Options:
  -a, --all          Cleanup all apps (alternative to '*')
  -g, --global       Cleanup a globally installed app
  -k, --cache        Remove outdated download cache

❯ sfsu cleanup -h
Cleanup apps by removing old versions

Usage: sfsu.exe cleanup [OPTIONS] [APPS]...

Arguments:
  [APPS]...  The app(s) to cleanup

Options:
  -a, --all          Cleanup all installed apps
  -k, --cache        Cleanup old versions of the app from the cache
      --dry-run      Print what would be done, but don't actually do anything
      --no-color     Disable terminal formatting [env: NO_COLOR=]
      --json         Print in the raw JSON output, rather than a human readable format, if the command supports it
  -v, --verbose      Show more information in outputs
      --debug        Enable debug logging
      --disable-git  Disable using git commands for certain parts of the program. Allows sfsu to work entirely if you
                     don't have git installed, but can negatively affect performance [env: DISABLE_GIT=]
  -g, --global       Use the global Scoop context
      --arch <ARCH>  Use the specified architecture, if the app and command support it [default: 64bit]
  -y, --assume-yes   Assume "yes" as answer to prompts
  -h, --help         Print help

[brian6932]

I'm straight up just having cleanup not consistently work, so maybe there's more to this.

❯ sfsu cleanup -a -g -v --debug
All squeaky clean!!

[jewlexx]

Sorry I've been pretty busy the last couple weeks. I'll keep looking into this when I have some time, but I think you're right, either something broke since I released the cleanup command or I didn't test it properly before release.

[jewlexx]

Sorry just getting back to this now, I think the issue might be that you're using the -g flag. sfsu's global support is limited at best at the moment, and frankly for me its not a priority until sfsu reaches closer feature parity with Scoop. Running sfsu cleanup -a should yield the expected results.

[letterk]

sfsu cleanup -a command is failing to consistently remove old versions of installed software, successfully cleaning some applications while ignoring others.

[jewlexx]

@letterk this has already been brought up. If you have any logs or helpful context to add that would be amazing but I am already looking into this issue.