feat: add dispatch rules for pinv and svd - #123
Open
alessandrogentili001 wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 83.09% 83.64% +0.54%
==========================================
Files 45 45
Lines 3827 3870 +43
==========================================
+ Hits 3180 3237 +57
+ Misses 647 633 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Dispatch Rules for
pinvandsvdRelated to #49
Summary
This PR adds specialized dispatch rules for
pinv(pseudoinverse) andsvd(singular value decomposition) for structured linear operators. These additions follow the existing patterns used byinv,logdet, andtraceto improve performance and numerical stability by exploiting operator structure.Changes
1.
pinvDispatch Rules (cola/linalg/inverse/pinv.py)2.
svdDispatch Rules (cola/linalg/svd/svd.py)3. Backend Additions
pinvtonp_fns.py(np.linalg.pinv) andjax_fns.py(jnp.linalg.pinv) to ensure consistency across all supported backends.Tests
I have added two new test files containing 18 tests covering all dispatch rules across NumPy, PyTorch, and JAX backends.
tests/linalg/inverse/test_pinv_dispatch.pytests/linalg/svd/test_svd_dispatch.pyVerification Criteria: