Separate test-image resolvconf setup from staging - #35
Merged
Merged
Conversation
Keep production staging focused on Tailscale DNS while configuring resolvconf only for DHCP-based test clones. Verify local MagicDNS resolution before continuing.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production staging should not install or manage
resolvconf; its responsibility is to enable Tailscale DNS and ensure MagicDNS is actually usable. The test-image workflow, which relies on DHCP inside nested Proxmox guests, does needresolvconfconfigured.This change:
resolvconffrom the production staging dependency list;resolvconfonly while preparing linked test clones, including the/etc/resolv.confsymlink, service activation, and refresh;Validation:
./tailmox testpasses all 38 test files, along with focused DNS and shell syntax checks.