Repository navigation
Support Direct2D source copies into clipped compatible targets - #274
Draft
wieslawsoltes wants to merge 4 commits into
Draft
wieslawsoltes wants to merge 4 commits into
wieslawsoltes wants to merge 4 commits into
Conversation
wieslawsoltes
added this pull request to stack #312
October 2, 2026 21:48
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scoped functionality
Adds
CopyFromBitmapandCopyFromRenderTargetinto compatible targets with active aliased axis-aligned destination clips. The shared builder suspends and restores those exact clip scopes around the existing immutable SRC copy transaction. Full replacement retains captured drawing scopes; partial writes retain history.This draft is stacked on #273 (
feat/direct2d-scoped-memory-copy), exact dependency4d159e87b6866f510c56abb512e32760d08cfb21. That dependency is not yet qualified. No automatic issue closure or general Direct2D compatibility claim is intended.Source active clips/layers and scoped self-copies remain rejected. Snapshot capture precedes destination locking; format, alpha, independent DPI, physical crop, original source errors and caller state remain authoritative. No source COM identity is retained, and no renderer fallback, C ABI/COM slot/wire change or default alteration is introduced.
Tests and qualification boundary
No local native binary was built or executed; no GPU, VM, runtime staging or Windows observation ran locally. Hosted full Build, both-provider pixels, original Windows controls and application qualification remain required. Syntax checks are not behavioral qualification.
Implementation provenance and Microsoft contract links are recorded in
docs/direct2d-scoped-source-copies.md.