Guard TOC decode, missing cdrdao output, and None FILE paths - #708
Open
ajzrva-sys wants to merge 3 commits into
Open
ajzrva-sys wants to merge 3 commits into
ajzrva-sys wants to merge 3 commits into
Conversation
- whipper-team#239/whipper-team#681: verifyTrack accepts existing EAC/resume files when testcrc is None and records the file CRC instead of always re-ripping - whipper-team#550: skip image verify/encode when index.path is None; toc.py no longer does s.path on a missing source - whipper-team#594: ReadTOCTask._done checks the TOC file exists and logs cdrdao returncode/stderr instead of FileNotFoundError on a random temp path - whipper-team#654: open TOC/cue with errors='replace'; decode cdrdao stderr the same way so non-UTF-8 CD-TEXT does not abort the rip Signed-off-by: ajzrva-sys <ajzrva-sys@users.noreply.github.com> Addresses whipper-team#239 Addresses whipper-team#550 Addresses whipper-team#594 Addresses whipper-team#654
The Fedora whipper-team#550 traceback is toc.py _index doing s.path when the silence source is None (generic cdrdao TOC). That site was already guarded; this closes the rest of the chain: - image.Image.setup: tolerate missing/None INDEX 1 path - program.verifyImage: skip AccurateRip paths when FILE is null - common.getRealPath(None) raises KeyError, not AttributeError - regression test: SILENCE + FILE data.wav TOC parses without crash Signed-off-by: ajzrva-sys <ajzrva-sys@users.noreply.github.com> Addresses whipper-team#550
…put guards whipper-team#239 — verifyTrack reuses EAC/resume files when testcrc is None and records the file CRC; truncated files still fail via MissingFrames. whipper-team#594 — ReadTOCTask._done refuses to parse a TOC cdrdao never wrote and logs returncode + stderr tail (device empty, crash, or concurrent rip). whipper-team#654 — decode all external tool output with errors='replace': cdrdao DetectCdr/version, cdparanoia progress/analyze, soxi, and VersionGetter, not only toc/cue file reads. Signed-off-by: ajzrva-sys <ajzrva-sys@users.noreply.github.com> Addresses whipper-team#239 Addresses whipper-team#594 Addresses whipper-team#654
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch of crash/error-handling fixes for accepted open bugs that had no PR:
Verification
Addresses #239
Addresses #550
Addresses #594
Addresses #654