Conversation
Collaborator
Author
|
Closing this approach in favor of a safer release-path fix: rebuild Apple release slices with official Apple archive tools and add a read-only archive alignment verifier, without custom byte mutation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a deterministic archive repair pass for Darwin static libraries so release artifacts guarantee 8-byte-aligned 64-bit Mach-O member payloads.
Root Cause
The
0.2.2release runner checked out the expected commit with theranlibchange, but the producedlibsvga-static-0.2.2.xcframework.zipstill haslibsvga_zcu.oat payload offset1660(4 mod 8). cctools behavior alone is not a stable enough invariant across runner/toolchain versions.Changes
tools/align_macho_archive.pyto parse BSDararchives and repair extended-name padding before 64-bit Mach-O payloads.libtoolandranlibintools/rearchive_macos.sh.Validation
0.2.2release archive locally;libsvga_zcu.omoved from offset1660to1672.zig build testzig build -Dtarget=aarch64-ios.15.0 -Doptimize=ReleaseFast -Dbuild-probe=false -p /tmp/libsvga-deterministic-ios-checkzig build package-release -Doptimize=ReleaseFast -Drelease-version=0.2.3-deterministic-check -Drelease-dir=/tmp/libsvga-deterministic-release-checklibsvga_zcu.oat payload offset1672, so1672 % 8 == 0.