python/yolov8: Use WENDY_JETPACK_MAJOR for Thor support - #14
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the python/yolov8 container build to select the Ultralytics runtime base image dynamically based on the JetPack major version (to support both Orin/JP6 and Thor/JP7), using a new WENDY_JETPACK_MAJOR build-arg provided by the Wendy build system.
Changes:
- Add
ARG WENDY_JETPACK_MAJOR=6to parameterize runtime base selection (defaulting to JP6 for local/Orin builds). - Introduce two named base stages (
base-6,base-7) and select the final runtime stage viaFROM base-${WENDY_JETPACK_MAJOR}.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This selects the correct ultralytics base image depending on whether the target is an Orin (JP6) or a Thor (JP7).
Relies on new build-arg supplied in wendylabsinc/WendyOS#1144