fix(pkg): pass workspace patterns from config to MonorepoDetector - #123
Merged
Conversation
The CLI was failing to find packages in directories like 'playground/*' despite being configured in repo.config.toml with patterns = ["packages/*", "playground/*"]. Root cause: MonorepoDetector was being created with default configuration instead of using the workspace patterns from repo.config.toml. Changes: - Add build_monorepo_config() to VersionResolver to merge workspace patterns from PackageToolsConfig into MonorepoConfig - Update detect_monorepo() and discover_monorepo_packages() to use MonorepoDetector::with_filesystem_and_config() - Add new_with_config() and with_filesystem_and_config() constructors to PackageMapper for passing config with workspace patterns - Add new_with_config() to PackageDetector for config-aware detection - Add full_config field to ChangesetManager to store complete config - Update ChangesAnalyzer to use PackageMapper::with_filesystem_and_config() - Update detect_affected_packages() in CLI to pass config parameter Also fixes: - Pre-existing large_futures clippy warning in dispatch.rs - Add #[allow(clippy::large_futures)] to audit test modules - Fix field_reassign_with_default warnings in changeset tests BREAKING CHANGE: ChangesetManager::with_storage() now requires PackageToolsConfig instead of ChangesetConfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI was failing to find packages in directories like 'playground/' despite being configured in repo.config.toml with patterns = ["packages/", "playground/*"].
Root cause: MonorepoDetector was being created with default configuration instead of using the workspace patterns from repo.config.toml.
Changes:
Also fixes:
BREAKING CHANGE: ChangesetManager::with_storage() now requires PackageToolsConfig instead of ChangesetConfig