fix(changelog): use HEAD as fallback when version tag does not exist - #121
Merged
Conversation
When generating changelogs during bump operations, the code was trying to use the new version tag as the to_ref for collecting commits. However, this tag does not exist yet at changelog generation time (Step 10), since tags are only created later (Step 12). This caused a ReferenceError when running: workspace bump --execute --git-commit --git-tag Changes: - Add reference_exists() helper method to check if a Git reference exists - Modify build_git_refs() to fallback to HEAD when the target version tag does not exist yet This ensures changelog generation works correctly in the normal bump workflow where changelogs are generated before Git tags are created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating changelogs during bump operations, the code was trying to use the new version tag as the to_ref for collecting commits. However, this tag does not exist yet at changelog generation time (Step 10), since tags are only created later (Step 12).
This caused a ReferenceError when running:
workspace bump --execute --git-commit --git-tag
Changes:
This ensures changelog generation works correctly in the normal bump workflow where changelogs are generated before Git tags are created.