fix(showcase): extract product card into headless component with ::pa… - #164
Merged
miguelramos merged 2 commits intoMar 27, 2026
Merged
Conversation
…rt() API Refactor the T3 e-commerce product card from inline Shadow DOM styles with hardcoded design tokens into a separate <sc-product-card> custom element that defines structure and layout only. All design system tokens (--line-*) are now applied externally by sc-page-playground via ::part() selectors, establishing the correct headless pattern for all showcase composition blocks. Resolves: line-ui-m3d.8
|
- Replace imperative DOM manipulation in _handleImageError with reactive Lit state (_imageError flag + conditional template) - Add documentation comment on inline style injection pattern in _renderColorDots as showcase-only, not for production use
miguelramos
deleted the
fix/line-ui-m3d-8-refactor-product-card-headless
branch
March 27, 2026 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rt() API
Refactor the T3 e-commerce product card from inline Shadow DOM styles with hardcoded design tokens into a separate custom element that defines structure and layout only. All design system tokens (--line-*) are now applied externally by sc-page-playground via ::part() selectors, establishing the correct headless pattern for all showcase composition blocks.
Resolves: line-ui-m3d.8