docs(storybook-spec): add concrete colorScheme companion decorator gu… - #158
Merged
miguelramos merged 2 commits intoMar 20, 2026
Merged
Conversation
…idance The withThemeByClassName decorator from @storybook/addon-themes only toggles CSS classes — it has no mechanism for setting inline styles. This left a gap where the spec said "should also set style.colorScheme" without explaining how. Add a companion decorator to the preview.ts code sample that syncs style.colorScheme based on the .dark class presence. Replace vague "should also set" prose in sections 4.2 and 7.1 with concrete cross-references to the new code sample.
miguelramos
added
📚 TYPE: Docs
|
…ment Storybook executes decorators first-to-last (each wraps the next), not bottom-to-top as previously stated. The companion decorator behavior was correct but the explanation could mislead implementors.
miguelramos
deleted the
chore/line-ui-p3v-47-colorscheme-decorator-guidance
branch
March 20, 2026 12:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…idance
The withThemeByClassName decorator from @storybook/addon-themes only toggles CSS classes — it has no mechanism for setting inline styles. This left a gap where the spec said "should also set style.colorScheme" without explaining how.
Add a companion decorator to the preview.ts code sample that syncs style.colorScheme based on the .dark class presence. Replace vague "should also set" prose in sections 4.2 and 7.1 with concrete cross-references to the new code sample.