SEI 24 Aurelia - #175
Open
loribean wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deliverable Submission
Please describe your comfort and completeness levels before submitting.
Comfort Level (1-5): 5
Completeness Level (1-5): 5
What did you think of this deliverable?:
it was fun
How many hours did you spend on this assignment? 4
What part did you spend the most time on? document.querySelector!!!!
Does the assignment run without errors? If the assignment has errors, what are they? No errors, currently. But I had to debug a few:
like
TypeError: Cannot set property 'innerText' of null at display
SyntaxError: Duplicate parameter name not allowed in this context.
Syntax Error: Illegal return statement
But easy to find out what's wrong after googling and using chrome dev tools
Describe one part of the code or choose one line you would improve upon. What would you improve?
Maybe the design. Also, a reset button to let the user rest the fields. Currently, the user will need to refresh the page
What did you think of this deliverable? Any other comments?