Skip to content

Keep phone reading controls visible and explain text checks accurately - #3

Merged
wcook04 merged 1 commit into
mainfrom
codex/proof-reader-phone-header
Nov 1, 2026
Merged

wcook04 merged 1 commit into
mainfrom
codex/proof-reader-phone-header

Conversation

@wcook04

@wcook04 wcook04 commented Nov 1, 2026

Copy link
Copy Markdown
Owner

Opening a statement on a phone added a Back button that pushed the reading/PDF controls beyond the screen. Let the existing header controls wrap, and add a browser regression for that state.

Correct the README, contributor guide, page footer and generated text description to explain what the PDF comparison actually checks. It skips some page regions and permits text rearrangements, so passing does not certify an exact copy. Use the tested installation command and describe the required result-and-passage entries. The original paper, PDF, Lean project and author credits are unchanged.

Validation:

  • Unit tests, source checks, paper checks, TypeScript and the production build pass.
  • A fresh clone adds a small second paper, extracts its three Lean declarations and comments, checks the links and builds a working reader. The synthetic fixture is kept out of the published papers.
  • Actual browser checks cover the original and second paper at desktop, laptop and 390-pixel phone widths, including PDF display, exact Lean lines, Back/Forward and control bounds. The new overflow assertions fail on the saved original build and pass on this change.
  • The local scripted browser journey could not finish launching. Its new regression steps were run through the connected browser instead; no scripted journey pass is claimed.

@wcook04
wcook04 merged commit 53a9159 into main Nov 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant