Repository navigation
Keep phone reading controls visible and explain text checks accurately - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a statement on a phone added a Back button that pushed the reading/PDF controls beyond the screen. Let the existing header controls wrap, and add a browser regression for that state.
Correct the README, contributor guide, page footer and generated text description to explain what the PDF comparison actually checks. It skips some page regions and permits text rearrangements, so passing does not certify an exact copy. Use the tested installation command and describe the required result-and-passage entries. The original paper, PDF, Lean project and author credits are unchanged.
Validation: