Repository navigation
fix: scope Azure DevOps guest git credentials to the host - #56
Merged
Merged
Conversation
In-container fetch against dev.azure.com failed with "Cannot determine the organization name" because the guest query was pathless while host Git Credential Manager requires the organization in the path. Seeding no longer replaces the global credential.helper list. dev.azure.com gets a URL-scoped helper override and useHttpPath. GitHub and other HTTPS hosts keep local store on clone and append-only helper on up/rebuild.
adevcontainerTests passed 1163.
Non-Azure HTTPS is unchanged. Only dev.azure.com gets a URL-scoped helper and useHttpPath, so a pathless query is not proxied to host GCM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git fetchagainsthttps://dev.azure.com/...failed with "Cannot determine the organization name" because the guest credential query was pathless while host Git Credential Manager requires the organization in the path.credential.helperlist.dev.azure.comgets a URL-scoped helper override (emptycredential.https://dev.azure.com.helper, then the product helper) andcredential.https://dev.azure.com.useHttpPath true. The product helper matches protocol and host and ignores path.credential.helper storeplus a pathless approve. Up and rebuild only append the product helper.Verification
swift run adevcontainerTests: 1163 passed, 0 failed, 5 skipped.ADEVCONTAINER_ALLOW_BUILD_ROSETTA_DISABLE=1 swift run --skip-update adevcontainer rebuild --name plantsuite --json --skip-pullkept volumeadev-plantsuite-efe596f5d495-ws.git fetch -pexited 0 with no organization-name fatal.