Repository navigation
market_data: historical encoder takes WhatToShow, not Option - #962
Open
tradatious wants to merge 1 commit into
Open
tradatious wants to merge 1 commit into
tradatious wants to merge 1 commit into
Conversation
encode_request_historical_data and validate_historical_data take a WhatToShow; every caller passed Some since the public API made it required (wboayue#573). The ToField impl for Option<WhatToShow> goes with it. No wire change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
encode_request_historical_dataandvalidate_historical_datatookOption<WhatToShow>, butevery caller has passed
Some(..)since the public API madewhat_to_showrequired (#573). Theynow take
WhatToShow.impl ToField for Option<WhatToShow>is removed with it;ToFieldis crate-private and nothingelse used the impl. The historical-data request builder used by the tests takes a plain
WhatToShowtoo, defaulting toTrades.No wire change.
Testing
The existing request-byte tests for
historical_data,historical_data_streamandhistorical_schedulepass with only theSome(..)wrappers removed from their expected requests.cargo fmt --check; clippy, rustdoc (-D warnings) and cargo test on all three feature
configurations; cargo build --examples both ways; integration crates built.
Breaking changes
No. Crate-internal.