Repository navigation
scanner: use the request builder for scanner_subscription - #960
Open
tradatious wants to merge 1 commit into
Open
tradatious wants to merge 1 commit into
tradatious wants to merge 1 commit into
Conversation
Both clients now use request() and builder.send instead of assembling the Subscription by hand, as market data and display groups do. No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
scanner_subscriptionon both clients minted a request id, sent the request and assembled theSubscriptionby hand. It now goes throughrequest()andsend(), as the news subscriptions dosince #947. The version checks ahead of the request are unchanged.
No behaviour change: the builder makes the same message-bus call with the same request id and the
same decoder context.
Testing
The existing scanner tests cover it:
test_scanner_subscriptionon both clients asserts therequest and cancel bytes, and the async
test_scanner_subscription_drop_sends_cancelcovers thecancel on drop; they pass unchanged. cargo fmt --check; clippy, rustdoc (-D warnings) and cargo
test on all three feature configurations; cargo build --examples both ways; integration crates
built.
Breaking changes
No. Crate-internal.