Repository navigation
client: re-export blocking tick/display-group subscriptions - #958
Open
tradatious wants to merge 1 commit into
Open
tradatious wants to merge 1 commit into
tradatious wants to merge 1 commit into
Conversation
client::blocking now exports the blocking TickSubscription, its four iterator types and DisplayGroupSubscription, so a build with both features can name them; the top-level names are the async types there.
tradatious
force-pushed
the
blocking-subscription-reexports
branch
from
October 5, 2026 07:23
e0bda67 to
e8396b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With both
syncandasyncenabled, the top-levelmarket_data::historical::TickSubscriptionanddisplay_groups::DisplayGroupSubscriptionare the async types. The blockingTickSubscriptionwasreachable there only through the hidden
historical::syncpath, and the blockingDisplayGroupSubscriptionhad no public path at all. So a caller ofblocking::Client::subscribe_to_group_eventscould not name the returned type, and a caller ofhistorical_ticks(..).trade()could name it only through a hidden module.client::blockingnow re-exports the blockingTickSubscription, its four iterator types andDisplayGroupSubscription, asdocs/rules/parity/dual-feature-types.mdprescribes for dual-featuretypes. The
blockingmodule docs gain an example that names both. The hiddenhistorical::syncpath is unchanged. The rule node records this as a precedent.
Testing
The new example on
client::blockingcompiles under--all-featuresand sync-only; without there-exports it fails with E0432. cargo fmt --check; clippy, rustdoc (-D warnings) and cargo test on
all three feature configurations; cargo build --examples both ways; integration crates built; rules
graph check.
Breaking changes
No. Additive re-exports only.