docs: props 테이블 줄바꿈 깨짐 수정 및 ElementType 타입 표기 보존 - #636
Conversation
- CodeBlock이 sx를 받도록 해 props 테이블 이름 셀을 keep-all로 유지하고 설명 아이콘이 줄어들지 않게 고정 - MDX 본문은 overflow-wrap: anywhere로 긴 토큰이 레이아웃을 밀어내지 않게 함 - api-generator가 제네릭 인자가 붙은 ElementType<...>도 보존 타입으로 인식해 as prop 타입이 풀어져 표기되지 않게 함 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 51 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. WalkthroughMDX CodeBlock이 외부 ChangesMDX 코드 표시
API 생성기 타입 보존
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change improves MDX wrapping and prop-table code display while preserving generic ElementType annotations in generated API documentation. No current merge-blocking behavior or production-impact risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
size-limit report 📦
|
docs 패키지는 @montage-ui/engine을 직접 의존하지 않아 WithSxProps import가 빌드에서 실패했다. core가 export하는 SxProp으로 대체한다. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
🚀 Preview
|
Summary
CodeBlock이sx를 받도록 하고 이름 셀에word-break: keep-all적용, 설명 아이콘에flex-shrink: 0overflow-wrap: anywhere로 바꿔 긴 토큰이 레이아웃을 밀어내지 않게 함ElementType<...>도 보존 타입으로 인식해asprop 타입이 풀어져 표기되지 않도록 수정배포 영향이 없는 docs / 스크립트 변경이라 마일스톤 없음.
Test plan
pnpm -F docs dev로 컴포넌트 문서의 props 테이블 렌더링 확인 (이름 셀 줄바꿈, 아이콘 크기)pnpm build:api후docs/generated/api.json에서asprop 타입이ElementType<...>로 유지되는지 확인Summary by CodeRabbit