Skip to content

add r1 signature - #22

Draft
weixuefeng wants to merge 4 commits into
wakumo:masterfrom
weixuefeng:master
Draft

add r1 signature#22
weixuefeng wants to merge 4 commits into
wakumo:masterfrom
weixuefeng:master

Conversation

@weixuefeng

Copy link
Copy Markdown

No description provided.

@ludowkm

ludowkm commented Aug 19, 2022

Copy link
Copy Markdown
Collaborator

hi @weixuefeng , thank you for your PR.
Can you describe detail about this new part please

@weixuefeng

Copy link
Copy Markdown
Author

i used newchain for sign message, newchain used secp256r1 algorithm and i had add signature r1 for eth-sig-util(dart).

i supply this merge for review code.
thanks for reply. @ludowkm

@juampiq6

Copy link
Copy Markdown

sorry but i think changing all the code with ifs, just to support one more elliptic curve, is not worth it. Maybe we should think about creating a EthSigUtil class which doesnt have static methods and which you can initialize with an specific curve to use parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants