Minor bugfixes from static analysis#506
Merged
Merged
Conversation
e.g. given "10.0.10" and "10.0.9", we want to choose the latest "10.0.10". But if we sort lexicographically we'd choose 10.0.9. Fix to actually parse the version numbers.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
=======================================
- Coverage 80.5% 80.5% -0.1%
=======================================
Files 130 130
Lines 9462 9481 +19
Branches 1417 1427 +10
=======================================
+ Hits 7618 7633 +15
- Misses 1354 1356 +2
- Partials 490 492 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a few issues uncovered from static analysis (missing
usingon IDisposable, null issues, multithreading access on non-thread-safe collections).