fix(#68): install deps in workflows, bump generator 7.12.0 -> 7.14.0 - #69
Merged
Merged
Conversation
maddawik
force-pushed
the
68-update-generate-workflow-to-install-deps
branch
2 times, most recently
from
August 1, 2025 22:32
8b8d375 to
6e2b6a7
Compare
maddawik
changed the title
maddawik
force-pushed
the
68-update-generate-workflow-to-install-deps
branch
2 times, most recently
from
August 2, 2025 18:43
1f0d726 to
4c0cee4
Compare
maddawik
changed the title
maddawik
force-pushed
the
68-update-generate-workflow-to-install-deps
branch
2 times, most recently
from
August 2, 2025 18:56
38caed3 to
15bd783
Compare
This commit resolves several problems: 1. Dependencies were not being installed pre-generate workflow (not found in tests when there were no new changes in our OpenAPI spec). 2. Tests were failing to run because of some dependency issues. I bumped OpenAPI generator CLI from 7.12.0 -> 7.14.0 which updates the minimum version needed for `urllib3` which resolves those failures. 3. The Makefile commands and the inline bash that was being used within the github workflows were not in-sync (things were `pip install`d and not all the `make` targets were leveraged). That's all been cleaned up so that `poetry` wraps every command (guaranteeing we're using the version we specify in the `pyproject.toml`) and that `make` targets are used in all of the workflows.
maddawik
force-pushed
the
68-update-generate-workflow-to-install-deps
branch
from
August 2, 2025 20:03
15bd783 to
6fa1bd7
Compare
[bot](2025-08-02 20:05:32) Sync SDK with OpenAPI spec Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit resolves several problems:
found in tests when there were no new changes in our OpenAPI spec).
OpenAPI generator CLI from 7.12.0 -> 7.14.0 which updates the minimum
version needed for
urllib3which resolves those failures.the github workflows were not in-sync (things were
pip installd andnot all the
maketargets were leveraged). That's all been cleanedup so that
poetrywraps every command (guaranteeing we're using theversion we specify in the
pyproject.toml) and thatmaketargetsare used in all of the workflows.
After these changes were made, the python sdk was regenerated from this
branch and merged in (see commits).