Repository navigation
fix: findComponent by selector on a functional root component - #2978
Open
ValentinYoushkevich wants to merge 1 commit into
Open
ValentinYoushkevich wants to merge 1 commit into
ValentinYoushkevich wants to merge 1 commit into
Conversation
When the selector matched the root element and the root component was functional (or a real <transition>), findComponent wrapped its null proxy and threw. Return a DOMWrapper for it, like findAllComponents and findComponent(Func) do.
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findComponent('<selector>')throws when the selector matches the root element of the component and that root is a functional component. The same happens with a real<transition>as root (stubs: { transition: false }), becauseTransitionis functional.The root match branch wrapped
subTree.component.proxy, which isnullfor a functional instance. Now a functional root component gets aDOMWrapper, the same asfindAllComponentsandfindComponent(Func)return for functional components. Stateful roots keep returning theirVueWrapper. This also fixesgetComponent('<selector>')and the same lookup from aDOMWrapper.Real code with this shape: jeecgboot-vue3
src/views/sys/lock/index.vueRepro on 2.5.1: playground