Repository navigation
fix: support attachTo on Vue versions before 3.5 - #2974
Merged
Merged
Conversation
app.onUnmount, used since vuejs#2700 to remove the attachTo container, only exists since Vue 3.5, so mounting with attachTo threw on older versions while the peer range is vue 3.x. Wrap app.unmount instead.
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
cexbrayat
reviewed
Oct 20, 2026
cexbrayat
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #2700,
mountwithattachTocallsapp.onUnmount, which only exists since Vue 3.5, so on Vue 3.0–3.4 it throwsTypeError: app.onUnmount is not a function(the peer range isvue: 3.x).This also breaks every
render()of@testing-library/vueon these versions, as it always passesattachToand depends on@vue/test-utils@^2.4.1.This uses
app.onUnmountwhen available and otherwise wrapsapp.unmount, so the container is still removed on unmount. I also ran the whole test suite against Vue 3.4.38: 3 tests fail on main, all pass with this change.Repro on 2.5.1 with Vue 3.4.38: playground