Repository navigation
fix(client): make pages route actions keyboard accessible - #1173
Open
ninadsutrave wants to merge 1 commit into
Open
ninadsutrave wants to merge 1 commit into
ninadsutrave wants to merge 1 commit into
Conversation
✅ Deploy Preview for vue-devtools-docs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the Pages panel, dynamic routes (e.g.
/projects/:slug) open their "Fill params and navigate" popover from a<code>element, and route meta opens from a<span>. Neither can be reached with Tab, and the route/param inputs only have placeholders.-and are no longer tab stops.Styling and click behaviour are unchanged. This is limited to
pages/pages.vueand doesn't overlap with #1146, #1170 or #1171.Relates to #885.
Validation
pnpm vitest run tests/integration/client/pages.test.ts(fails on the original code, passes with the fix)pnpm lint,pnpm typecheck,pnpm format:check,pnpm buildpnpm test(68 files, 418 tests passed)