Repository navigation
fix(kit): keep scheduler draining after a batch rejects - #1160
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
✅ Deploy Preview for vue-devtools-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When `run()` was called while a batch was in flight, it chained the follow-up with `running.then(...)` and no rejection handler. If any task in that batch threw, the follow-up never ran, queued tasks stayed in the map, and `pending` stayed `true`, so `schedule()` never armed another run. All later scheduled work (e.g. component updates) was silently dropped until `clear()`.
The follow-up now runs on both fulfilment and rejection. The caller that started the failing batch still receives its error.
Added a regression test in `tests/unit/runtime/scheduler.test.ts`; it fails without the fix. `pnpm vitest run tests/unit` passes (265 tests).
🤖 Generated with Claude Code