Repository navigation
fix(kit): resolve timeline component names before registration - #1157
Merged
Merged
Conversation
Performance and component-emit events can fire before the component is registered (e.g. during init and the first render), so the registry lookup failed and the timeline showed "Unknown Component". Fall back to reading the name from the instance, matching the component tree. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for vue-devtools-docs canceled.
|
commit: |
There was a problem hiding this comment.
🟡 Changes recommended
The corrected pre-registration behavior lacks regression assertions in the existing timeline tests.
2 open findings
What changed in this PR
Resolves timeline component names before registry registration.
Changes:
- Reuses registry name resolution for timeline events.
- Handles component emit and performance events consistently.
| File | Description |
|---|---|
packages/kit/src/runtime/timeline.ts |
Resolves names directly from unregistered instances. |
packages/kit/src/runtime/registry.ts |
Exports the shared name resolver. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.