refactor(charts): extract shared internals - #2160
Draft
rodorgas wants to merge 1 commit into
Draft
Conversation
With the bar chart's requirements known and the line chart about to need the same shape, extract the shared series/axis/legend/tooltip mapping out of bar-option into internal/ so the upcoming LineChart composes it instead of duplicating it. Pure refactor: zero public-API change. - internal/series: ChartSeries, collapseSeries, createDeltaLookup, seriesLimit, defaultMaxSeries - internal/option: buildLegend, buildGrid, buildCategoryAxis, buildValueAxis, buildAxisTooltip + shared token constants - internal/messages: shared empty/others messages + ChartMessages type, moved from bar-chart/messages - tooltip-echarts: export the engine adapter interfaces so the shared tooltip builder's return type is nameable in declaration emission
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the bar chart's requirements known and the line chart about to need the same shape, extract the shared series/axis/legend/tooltip mapping out of
bar-optionintointernal/so the upcoming LineChart composes it instead of duplicating it. Pure refactor: zero public-API change.internal/series:ChartSeries,collapseSeries,createDeltaLookup,seriesLimit,defaultMaxSeriesinternal/option:buildLegend,buildGrid,buildCategoryAxis,buildValueAxis,buildAxisTooltip+ shared token constantsinternal/messages: sharedempty/othersmessages +ChartMessagestype, moved frombar-chart/messagestooltip-echarts: export the engine adapter interfaces so the shared tooltip builder's return type is nameable in declaration emissionVerification: 100 tests pass,
tsc --noEmitclean,biome checkclean, full build succeeds. Public.d.tsunchanged — no internal types leaked.Session cost