docs(charts): mark BarChart as experimental in the guide - #2157
Conversation
Adds a Callout to the bar-chart guide warning consumers that BarChart is experimental: it ships in @vtex/shoreline-charts at 0.x, so its API and visuals may change between minor versions. The JSDoc already carries @status experimental (surfaced in the generated props as status: 'experimental'), and no beta/rc npm dist-tag is needed since the 0.x version already signals instability.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe ChangesBarChart documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Mergeability Score: ⚪ Minimal · up to This localized documentation change clarifies that BarChart is experimental without changing runtime behavior, so no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rodorgas
left a comment
There was a problem hiding this comment.
docs: improve callout text
Summary
Follow-up to #2147 addressing the post-merge feedback on the BarChart docs. Three points were raised:
0.x, which already signals instability.What changed
1. Beta/rc tag — no change needed
@vtex/shoreline-chartspublishes with only alatestdist-tag (currently0.2.1) and the release workflow (lerna publishwith no--tag) introduces nobeta/rctag. The0.xversion already conveys instability, so nothing to add or remove.2. Experimental notice in the docs — added
Added a Nextra
<Callout>right under the component description onbar-chart.mdx, the page consumers land on to install and use the component:This mirrors the existing
Calloutpattern used intable/figma-usage.mdx.3. JSDoc — already present
BarChartalready carries@status experimentalin its JSDoc (packages/charts/src/components/bar-chart/bar-chart.tsx), matching the@statusconvention from the documentation guideline. The props build picks it up —__props__/index.tshasstatus: 'experimental'forbar-chart— so the experimental status is captured in the generated docs data. No change needed.Test plan
pnpm --filter @shoreline/docs gen:propssucceeds —bar-chartstill resolves withstatus: 'experimental'pnpm --filter @shoreline/docs gen:examplessucceedsnext buildinpackages/docssucceeds (full site)/components/bar-chartHTML (Experimental./not stable yet: it ships in)Related
docs(charts): add bar chart guide and best practices(the merged PR this follows up on)Session cost
Summary by CodeRabbit
BarChartdocumentation.