Add the selectedProperties to products.gql - #190
Open
juliabrzvtex wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Add the
selectedPropertiesto products.gqlWhat problem is this solving?
For stores that do the IS configuration to SKU specifications to display individual products in search results, a query string is added to the product link to direct it to the PDP correctly.
For the correct creation of the link with the query string, the product context must have the selectedProperties field https://github.com/vtex-apps/product-summary-context/blob/2db0baacbb46d5abca53999aac0a348c26916c09/react/ProductSummaryContext.tsx#L143
The problem is that the list-context.product-list context uses the products query from vtex.store-resources which does not have this field. https://github.com/vtex-apps/store-resources/blob/master/react/queries/products.gql
The PDP context already uses the productSearchV3 query which has the selectedProperties https://github.com/vtex-apps/store-resources/blob/master/react/queries/productSearchV3.gql
As in search-graphql this information is present in the products query, I just added it to products.gql.
How should this be manually tested?
Activate the configuration in the IS, and see that in the PLP, the product link has the query string
property__${key}, but the same product on the shelf this query string is not present.Screenshots or example usage
Search settings:
Workspace without the fix:

https://nofix--uniandes.myvtex.com/
Workspace with the fix:

https://pruebavtex--uniandes.myvtex.com/
Types of changes